feat: add SetType and SetContentType helpers for Token#525
Open
happysnaker wants to merge 1 commit into
Open
Conversation
Adds Token.SetType(typ) and Token.SetContentType(cty) methods as convenience helpers for setting the 'typ' and 'cty' header parameters defined in RFC 7519 Sections 5.1 and 5.2. These methods improve discoverability for registered header parameters compared to directly mutating Token.Header. Closes golang-jwt#497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #497
Adds
Token.SetType(typ)andToken.SetContentType(cty)convenience methods for setting the"typ"and"cty"header parameters defined in RFC 7519 Sections 5.1 and 5.2.Motivation
Currently, applications must mutate
Token.Headerdirectly to set these registered header parameters:This is error-prone (typos in key names) and doesn't help with discoverability of these standard parameters.
Changes
Added two small helper methods:
These simply modify
Token.Headerinternally and do not change signing or validation behavior.